Add additional Plex test to IGNORE_UNCAUGHT_EXCEPTIONS list#33397
Closed
dmulcahey wants to merge 1 commit intohome-assistant:devfrom
Closed
Add additional Plex test to IGNORE_UNCAUGHT_EXCEPTIONS list#33397dmulcahey wants to merge 1 commit intohome-assistant:devfrom
dmulcahey wants to merge 1 commit intohome-assistant:devfrom
Conversation
20 tasks
Contributor
|
This shouldn't be necessary if #33398 is merged. |
Contributor
Author
|
Closing in favor of #33398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds an additional Plex test to the ignore uncaught exceptions list to fix dev builds. Currently builds: #33391, #33393, #33395 are failing with this:
It looks like a guard is needed around
self._current_task.cancel()in close onPlexWebsocketbut that is in a lib and would require a lib update.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: