Add config_flow for Roomba#33302
Merged
bdraco merged 111 commits intohome-assistant:devfrom Apr 11, 2020
Merged
Conversation
bdraco
reviewed
Mar 27, 2020
bdraco
reviewed
Mar 27, 2020
bdraco
reviewed
Mar 27, 2020
bdraco
reviewed
Mar 27, 2020
bdraco
reviewed
Mar 27, 2020
bdraco
reviewed
Mar 27, 2020
bdraco
reviewed
Mar 27, 2020
bdraco
reviewed
Mar 27, 2020
Member
|
@cyr-ius Does this need an upstream change in roombapy per pschmitt/roombapy#25? |
bdraco
requested changes
Mar 27, 2020
Member
bdraco
left a comment
There was a problem hiding this comment.
Thanks for doing this! Please see my comments above.
bdraco
reviewed
Mar 28, 2020
bdraco
reviewed
Apr 10, 2020
bdraco
reviewed
Apr 10, 2020
bdraco
reviewed
Apr 10, 2020
bdraco
reviewed
Apr 10, 2020
bdraco
reviewed
Apr 10, 2020
Member
|
confirmed multiple roomba working now. Docs are almost there. Just that last bit of cleanup mentioned above and I think this is good to go! 🎉 |
Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: J. Nick Koston <nick@koston.org>
bdraco
reviewed
Apr 11, 2020
Co-Authored-By: J. Nick Koston <nick@koston.org>
Member
|
Thanks. Retesting now |
bdraco
reviewed
Apr 11, 2020
Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: J. Nick Koston <nick@koston.org>
Member
|
@cyr-ius Retested, everything looks good. Since I'm the only one who has looked at this one, it is possible another reviewer may have additional change requests for a followup PR. |
Member
|
@cyr-ius any more changes coming or ok to merge now? |
Contributor
Author
|
OK merge now |
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please address the comments in a new PR. Thanks!
Contributor
Author
|
I have made the requested changes in PR #34089 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The
roombaintegration can now be configured in the UI, and provides additional sensors.The yaml configuration format has changed, and must be re-setup.
Proposed change
Add config_flow for iRobots Roomba
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: