Skip to content

Add config_flow for Roomba#33302

Merged
bdraco merged 111 commits intohome-assistant:devfrom
cyr-ius:roomba
Apr 11, 2020
Merged

Add config_flow for Roomba#33302
bdraco merged 111 commits intohome-assistant:devfrom
cyr-ius:roomba

Conversation

@cyr-ius
Copy link
Copy Markdown
Contributor

@cyr-ius cyr-ius commented Mar 27, 2020

Breaking change

The roomba integration can now be configured in the UI, and provides additional sensors.

The yaml configuration format has changed, and must be re-setup.

Proposed change

Add config_flow for iRobots Roomba

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: #12793

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @pschmitt, mind taking a look at this pull request as its been labeled with a integration (roomba) you are listed as a codeowner for? Thanks!

Comment thread homeassistant/components/roomba/vacuum.py
Comment thread homeassistant/components/roomba/config_flow.py Outdated
Comment thread homeassistant/components/roomba/config_flow.py Outdated
Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/vacuum.py
Comment thread tests/components/roomba/test_config_flow.py Outdated
Comment thread tests/components/roomba/test_config_flow.py Outdated
Comment thread tests/components/roomba/test_config_flow.py Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 27, 2020

@cyr-ius Does this need an upstream change in roombapy per pschmitt/roombapy#25?

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Please see my comments above.

@springstan springstan changed the title Config_flow Roomba Add config_flow for Roomba Mar 27, 2020
Comment thread homeassistant/components/roomba/__init__.py Outdated
Comment thread homeassistant/components/roomba/__init__.py Outdated
Comment thread homeassistant/components/roomba/__init__.py Outdated
Comment thread homeassistant/components/roomba/__init__.py Outdated
Comment thread homeassistant/components/roomba/__init__.py Outdated
Comment thread homeassistant/components/roomba/__init__.py Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 11, 2020

confirmed multiple roomba working now. Docs are almost there. Just that last bit of cleanup mentioned above and I think this is good to go! 🎉

cyr-ius and others added 5 commits April 11, 2020 14:23
Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: J. Nick Koston <nick@koston.org>
Comment thread homeassistant/components/roomba/sensor.py Outdated
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyr-ius and others added 2 commits April 11, 2020 15:52
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 11, 2020

Thanks. Retesting now

Comment thread homeassistant/components/roomba/__init__.py Outdated
Comment thread homeassistant/components/roomba/__init__.py Outdated
cyr-ius and others added 2 commits April 11, 2020 16:11
Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: J. Nick Koston <nick@koston.org>
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 11, 2020

@cyr-ius Retested, everything looks good.

Since I'm the only one who has looked at this one, it is possible another reviewer may have additional change requests for a followup PR.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 11, 2020

@cyr-ius any more changes coming or ok to merge now?

@cyr-ius
Copy link
Copy Markdown
Contributor Author

cyr-ius commented Apr 11, 2020

OK merge now

@bdraco bdraco merged commit 8c4a139 into home-assistant:dev Apr 11, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments in a new PR. Thanks!

Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/binary_sensor.py
Comment thread homeassistant/components/roomba/binary_sensor.py
Comment thread homeassistant/components/roomba/binary_sensor.py
@cyr-ius cyr-ius mentioned this pull request Apr 12, 2020
20 tasks
@cyr-ius
Copy link
Copy Markdown
Contributor Author

cyr-ius commented Apr 12, 2020

I have made the requested changes in PR #34089

@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants