Add counters for GitHub repo forks, clones, views#33300
Merged
bdraco merged 2 commits intohome-assistant:devfrom Apr 8, 2020
Merged
Add counters for GitHub repo forks, clones, views#33300bdraco merged 2 commits intohome-assistant:devfrom
bdraco merged 2 commits intohome-assistant:devfrom
Conversation
Member
|
@timmo001 Can you take a look at this? |
timmo001
reviewed
Apr 5, 2020
timmo001
reviewed
Apr 5, 2020
timmo001
approved these changes
Apr 5, 2020
Member
|
Thanks @timmo001 |
Member
|
@renemarc Do you want to make adjustments or merge as-is? |
Contributor
Author
Contributor
Author
|
@timmo001 The PR was updated with your suggestions! |
Contributor
Member
If you make it a Let's keep the scope as-is on this one. If someone wants to do that in a followup it will be much easier to review small chunks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Breaking change
Proposed change
As a developer, it always feels good to see your code used and enjoyed by many people. To measure such code usefulness to the world, GitHub showcases a few key indicators for each repos: number of watchers, stargazers, contributors, forks, clones, views, issues, PRs.
The GitHub integration already offers a few:
This PR aims to add these other health counters:
While more data means more API calls, the usefulness of the returned indicators justifies the few extra queries.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: