Update PySwitchbot to 0.8.0 and add password configuration option#33252
Merged
Conversation
Contributor
|
Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration ( |
Danielhiversen
requested changes
Mar 25, 2020
Member
Danielhiversen
left a comment
There was a problem hiding this comment.
Please test that the code works locally
Contributor
Author
Will test and do up the documentation PR tomorrow, I'm new to Python so I'll probably take awhile with the testing. |
springstan
requested changes
Mar 25, 2020
Contributor
Author
|
Okay, I've just tested it on my Switchbot with a password set, all is working. Doing up the documentation markdown now. |
7 tasks
springstan
approved these changes
Mar 26, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
LGTM 👍 code owner should approve as well before we merge this.
klaasnicolaas
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Switchbot integration does not support password authentication #33238
Proposed change
Update PySwitchbot to 0.8.0 and add password attribute to configure
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Add password configuration field to Switchbot home-assistant.io#12516
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: