Skip to content

Update PySwitchbot to 0.8.0 and add password configuration option#33252

Merged
Danielhiversen merged 4 commits into
home-assistant:devfrom
jarylc:dev
Mar 26, 2020
Merged

Update PySwitchbot to 0.8.0 and add password configuration option#33252
Danielhiversen merged 4 commits into
home-assistant:devfrom
jarylc:dev

Conversation

@jarylc
Copy link
Copy Markdown
Contributor

@jarylc jarylc commented Mar 25, 2020

Breaking change

Switchbot integration does not support password authentication #33238

Proposed change

Update PySwitchbot to 0.8.0 and add password attribute to configure

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
switch:
  - platform: switchbot
    mac: 'fe:36:cf:72:1a:f3'
    password: password

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @jarylc,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration (switchbot) you are listed as a codeowner for? Thanks!

Copy link
Copy Markdown
Member

@Danielhiversen Danielhiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test that the code works locally

@jarylc
Copy link
Copy Markdown
Contributor Author

jarylc commented Mar 25, 2020

Please test that the code works locally

Will test and do up the documentation PR tomorrow, I'm new to Python so I'll probably take awhile with the testing.

Comment thread homeassistant/components/switchbot/switch.py Outdated
Comment thread homeassistant/components/switchbot/switch.py Outdated
@jarylc
Copy link
Copy Markdown
Contributor Author

jarylc commented Mar 26, 2020

Okay, I've just tested it on my Switchbot with a password set, all is working. Doing up the documentation markdown now.

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 code owner should approve as well before we merge this.

@springstan springstan changed the title Update PySwitchbot to 0.8.0 and added password configuration Update PySwitchbot to 0.8.0 and add password configuration option Mar 26, 2020
Copy link
Copy Markdown
Member

@Danielhiversen Danielhiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Danielhiversen Danielhiversen merged commit 6c6318d into home-assistant:dev Mar 26, 2020
klaasnicolaas pushed a commit to home-assistant/home-assistant.io that referenced this pull request Mar 27, 2020
@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switchbot integration does not support password authentication

4 participants