Skip to content

Add Android TV cover art (screen content)#33232

Merged
balloob merged 9 commits into
home-assistant:devfrom
i00:kb_adb
Mar 26, 2020
Merged

Add Android TV cover art (screen content)#33232
balloob merged 9 commits into
home-assistant:devfrom
i00:kb_adb

Conversation

@i00
Copy link
Copy Markdown
Contributor

@i00 i00 commented Mar 25, 2020

Breaking change

Proposed change

Add live screen capture to the Android TV integration (HDCP (protected) content is not shown)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
#No changes to existing integration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: Not required

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @JeffLIrion, mind taking a look at this pull request as its been labeled with a integration (androidtv) you are listed as a codeowner for? Thanks!

Comment thread homeassistant/components/androidtv/media_player.py Outdated
Comment thread homeassistant/components/androidtv/media_player.py Outdated
Comment thread homeassistant/components/androidtv/media_player.py
Comment thread homeassistant/components/androidtv/media_player.py Outdated
Comment thread homeassistant/components/androidtv/media_player.py Outdated
@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 26, 2020

Looks good from my end. Left one final comment. @JeffLIrion what do you think ?

Comment thread homeassistant/components/androidtv/media_player.py Outdated
Comment thread homeassistant/components/androidtv/media_player.py Outdated
@JeffLIrion
Copy link
Copy Markdown
Contributor

Looks good from my end. Left one final comment. @JeffLIrion what do you think ?

I left a couple minor comments. Once those are addressed, it looks good to me. @i00 have you tested this and confirmed that it works?

@i00
Copy link
Copy Markdown
Contributor Author

i00 commented Mar 26, 2020

@JeffLIrion ... Sorry thought I had addressed everything that you mentioned ... can you let me know what I missed?
EDIT: sorry just realized the time that you posted that :P ... let me know if there is anything else :)

Works for me on my Nvidia Shield, phone, and my mates TV (not sure what type of TV it is though).

@JeffLIrion
Copy link
Copy Markdown
Contributor

Looks good to me.

@springstan springstan changed the title Android TV cover art (screen content) Add Android TV cover art (screen content) Mar 26, 2020
@balloob balloob merged commit 3dc6612 into home-assistant:dev Mar 26, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants