Skip to content

Config flow for doorbird#33165

Merged
pvizeli merged 11 commits into
home-assistant:devfrom
bdraco:doorbird_config_flow
Mar 23, 2020
Merged

Config flow for doorbird#33165
pvizeli merged 11 commits into
home-assistant:devfrom
bdraco:doorbird_config_flow

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 22, 2020

Proposed change

Config Flow for doorbird

  • Discoverable via zeroconf

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

* Discoverable via zeroconf
@probot-home-assistant
Copy link
Copy Markdown

Hey there @oblogic7, mind taking a look at this pull request as its been labeled with a integration (doorbird) you are listed as a codeowner for? Thanks!

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 22, 2020

Yes discovery really is axis-video

2020-03-22 21:15:26 DEBUG (zeroconf-ServiceBrowser__axis-video._tcp.local.) [homeassistant.components.zeroconf] Discovered new device Doorstation - 1CCAE37179C7._axis-video._tcp.local. {'host': '192.168.209.67', 'port': 80, 'hostname': 'bha-1CCAE37179C7.local.', 'type': '_axis-video._tcp.local.', 'name': 'Doorstation - 1CCAE37179C7._axis-video._tcp.local.', 'properties': {'_raw': {'macaddress': b'1CCAE37179C7'}, 'macaddress': '1CCAE37179C7'}}
2020-03-22 21:15:26 DEBUG (zeroconf-ServiceBrowser__axis-video._tcp.local.) [homeassistant.components.zeroconf] Discovered new device Doorstation - 1CCAE370C917._axis-video._tcp.local. {'host': '192.168.213.186', 'port': 80, 'hostname': 'bha-1CCAE370C917.local.', 'type': '_axis-video._tcp.local.', 'name': 'Doorstation - 1CCAE370C917._axis-video._tcp.local.', 'properties': {'_raw': {'macaddress': b'1CCAE370C917'}, 'macaddress': '1CCAE370C917'}}
2020-03-22 21:15:26 DEBUG (zeroconf-ServiceBrowser__axis-video._tcp.local.) [homeassistant.components.zeroconf] Discovered new device Doorstation - 1CCAE3713152._axis-video._tcp.local. {'host': '192.168.213.143', 'port': 80, 'hostname': 'bha-1CCAE3713152.local.', 'type': '_axis-video._tcp.local.', 'name': 'Doorstation - 1CCAE3713152._axis-video._tcp.local.', 'properties': {'_raw': {'macaddress': b'1CCAE3713152'}, 'macaddress': '1CCAE3713152'}}
2020-03-22 21:15:26 DEBUG (zeroconf-ServiceBrowser__axis-video._tcp.local.) [homeassistant.components.zeroconf] Discovered new device Doorstation - 1CCAE3719E4B._axis-video._tcp.local. {'host': '192.168.209.181', 'port': 80, 'hostname': 'bha-1CCAE3719E4B.local.', 'type': '_axis-video._tcp.local.', 'name': 'Doorstation - 1CCAE3719E4B._axis-video._tcp.local.', 'properties': {'_raw': {'macaddress': b'1CCAE3719E4B'}, 'macaddress': '1CCAE3719E4B'}}

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 22, 2020

Zero conf tests are failing. I don’t think it’s aware that two devices types can have the same zero conf signatures

@bdraco bdraco requested a review from Kane610 March 22, 2020 23:33
Comment thread homeassistant/components/doorbird/__init__.py
Comment thread homeassistant/components/doorbird/__init__.py
Comment thread homeassistant/components/doorbird/__init__.py
Comment thread homeassistant/components/doorbird/__init__.py Outdated
Comment thread homeassistant/components/doorbird/__init__.py Outdated
Comment thread homeassistant/components/doorbird/config_flow.py
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
Comment thread homeassistant/components/doorbird/config_flow.py Outdated
Comment thread homeassistant/components/doorbird/entity.py Outdated
Comment thread homeassistant/components/doorbird/entity.py Outdated
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 23, 2020

Retesting now

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 23, 2020

All still working as expected. Would be nice to auto handle IP address changes for doorbird, but it didn't do that before so something for a followup.

@pvizeli pvizeli merged commit f9a7c64 into home-assistant:dev Mar 23, 2020
@oblogic7
Copy link
Copy Markdown
Contributor

Thanks for making these changes @bdraco. Been on my list to do for a while, but haven't found the time to dig in and figure out the config flow stuff.

Comment thread tests/components/doorbird/test_config_flow.py
@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants