Options flow for Monoprice sources#33156
Conversation
|
@balloob @MartinHjelmare this is the options flow followup we discussed in #30337. One problem I'm not sure how to resolve - since the options flow uses the Voluptuous Also, I think this integration is now a candidate for Gold on the quality scale. What do you think? |
balloob
left a comment
There was a problem hiding this comment.
This looks ok. I don't have a solution for being able to remove an optional value. I know that we recently made a change for something similar in the frontend, but I can't recall nor find it, so I don't know if I am imagining it.
|
Thanks @balloob. Where would be a good place to open a ticket for the removal of an optional value, so that we're aware of the current limitation and hopefully find a solution in the future? Is that in the frontend repo or arch repo (since it's the backend that's currently controlling it)? |
|
https://github.com/home-assistant/frontend. But it's difficult, because in most cases you do want the default :( So we would need a way to indicate |
Proposed change
Following up on the recent changes to the Monoprice integration, this PR enables the use of options flow to reconfigure sources.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: