Tankerkoenig UUIDs are not UUIDv4#33121
Closed
guillempages wants to merge 1 commit intohome-assistant:devfrom
Closed
Tankerkoenig UUIDs are not UUIDv4#33121guillempages wants to merge 1 commit intohome-assistant:devfrom
guillempages wants to merge 1 commit intohome-assistant:devfrom
Conversation
Merged
Contributor
Author
|
@balloob this fixes the UUIDv4 issue for tankerkoenig. |
d557a07 to
41be266
Compare
balloob
reviewed
Mar 21, 2020
|
|
||
| def uuid4_string(value): | ||
| """Validate a v4 UUID in string format.""" | ||
| def uuid_string(value): |
Member
There was a problem hiding this comment.
Why even validate it as uuid at all ?
Contributor
Author
|
Removed the whole validation code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Validate against generic UUIDs, not requiring v4 UUIDs
It turns out, that the UUIDs used by the tankerkoenig.de site are not using v4; so forcing the validator to UUIDv4 might break the integration for some users. Validating against generic UUIDs (no specific version) fixes the issue.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: