Fix Extend ONVIF unique ID with profile index#33103
Merged
Conversation
balloob
approved these changes
Mar 21, 2020
balloob
pushed a commit
that referenced
this pull request
Mar 21, 2020
Merged
balloob
pushed a commit
that referenced
this pull request
Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
In #32093 unique IDs for the ONVIF integration was added by me, however, I did not take into account an ONVIF capable device that can deliver multiple cameras (e.g., by a DVR or other aggregators).
This PR adjusts the unique ID to take the camera profile index into account. I've implemented it to use the hardware mac address when using profile
0and hardware mac address + profile index otherwise. That will ensure it isn't a breaking change for current users.I've tested it locally by adding a ONVIF capable test camera with multiple profiles.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: