Fix tankerkoenig with more than 10 stations#33098
Conversation
d2c84d7 to
fb8d19c
Compare
There seemed to be a problem, if more than 10 fuel stations were tracked. Added a warning in this case, and split the calls to the API in chunks of 10, so that the data can be fetched anyway.
fb8d19c to
f55fc91
Compare
MartinHjelmare
left a comment
There was a problem hiding this comment.
Good! Just a clean up.
|
Should we tag this for a patch release? |
|
I'd say yes. The integration was just added on the 0.107 release, so fixing its newborn bugs soon is good IMHO ;-) There might be a merge conflict later on with the UUID validator PR that was early accepted today (#32805); might be worth putting that in as well. But AFAIK, that's not my call ;-) |
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
|
Ok, since the other PR has already been merged to dev, I'm not sure we can apply this cleanly to master. If you still want to try, please verify how a cherrypick of this PR would work on master branch. |
|
The code would work OK (I actually implemented and tested it without the other one); there is just a minor conflict in the imports; since both PRs are adding a new import. Should be trivial to fix (I actually rebased and had the commit myself), but must be done manually. I don't know what's the policy here, or who should then do the merge. |
|
I don't know if we accept merge conflicts during cherry-picking. We want to do it automatically with this script: @balloob ? |
|
Will pick both. |
* Fix tankerkoenig with more than 10 stations There seemed to be a problem, if more than 10 fuel stations were tracked. Added a warning in this case, and split the calls to the API in chunks of 10, so that the data can be fetched anyway. * Update homeassistant/components/tankerkoenig/__init__.py Co-Authored-By: Martin Hjelmare <marhje52@gmail.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
* Fix tankerkoenig with more than 10 stations There seemed to be a problem, if more than 10 fuel stations were tracked. Added a warning in this case, and split the calls to the API in chunks of 10, so that the data can be fetched anyway. * Update homeassistant/components/tankerkoenig/__init__.py Co-Authored-By: Martin Hjelmare <marhje52@gmail.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
|
Aah so in the end with the conflict because the other validation was bad and required another PR to fix it in the same hotfix. |
|
yes, sorry again. #32805 should be completely removed (also from dev). Should I do a PR reverting it, or will you do some git magic behind the scenes? |
|
PR to revert it. |
|
Done: #33123 |
There seemed to be a problem, if more than 10 fuel stations were tracked.
Added a warning in this case, and split the calls to the API in chunks of
10, so that the data can be fetched anyway.
Proposed change
Fix issue #33061
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: