Fix totalconnect AttributeError introduced in 0.107#33079
Merged
balloob merged 5 commits intohome-assistant:devfrom Mar 21, 2020
Merged
Fix totalconnect AttributeError introduced in 0.107#33079balloob merged 5 commits intohome-assistant:devfrom
balloob merged 5 commits intohome-assistant:devfrom
Conversation
Member
|
There are unrelated commits in this PR. Could you please clean it up? Thanks! 👍 |
MartinHjelmare
requested changes
Mar 21, 2020
| mock_client.is_triggered_fire.return_value = True | ||
| mock_client.is_triggered_gas.return_value = True | ||
|
|
||
| alarm = TotalConnectAlarm("test", "123456", mock_client) |
Member
There was a problem hiding this comment.
We should not instantiate the entity directly. Instead set up the component and platform let it add an entity and then assert the state of the entity via the state machine. Make sure to patch the library appropriately to avoid I/O.
See eg:
core/tests/components/manual/test_alarm_control_panel.py
Lines 85 to 121 in e87fab6
Member
|
Please do not push revert commits but start a new branch. |
balloob
approved these changes
Mar 21, 2020
Contributor
Author
|
Since this is a bugfix for something broken right now, if it's o.k. I will work to improve the tests in a separate PR. |
Member
|
Yes, that's fine. Please make sure the build passes, then we can merge. |
MartinHjelmare
approved these changes
Mar 21, 2020
balloob
pushed a commit
that referenced
this pull request
Mar 21, 2020
* Fit git * Remove period from loggging message * Remove tests for now * Add const.py * Fix lint error
Merged
balloob
pushed a commit
that referenced
this pull request
Mar 21, 2020
* Fit git * Remove period from loggging message * Remove tests for now * Add const.py * Fix lint error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Updates totalconnect's alarm_control_panel code to account for changes in total-connect-client 0.54.1.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: