Skip to content

Clean up Sonos attributes for radio streams#33063

Merged
balloob merged 1 commit intohome-assistant:devfrom
amelchio:sonos-radio-attributes
Mar 21, 2020
Merged

Clean up Sonos attributes for radio streams#33063
balloob merged 1 commit intohome-assistant:devfrom
amelchio:sonos-radio-attributes

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

Breaking change

  • Sonos entities playing radio streams used to cram the radio name, the artist and the song name into two attributes. They now have media_artist and media_title attributes that simply match the playing music (when available).
  • Radio station artwork is no longer available for Sonos entities in polling mode (i.e. on a network separate to the network Home Assistant is on).

Proposed change

Sonos apps have multiple display modes, like one for music streaming and one for radio streaming. The Sonos media_player integration has tried to mimic this by slightly misusing the entity attributes.

This PR removes all the special handling that tried to build information similar to Sonos apps and now simply uses the attributes that HA supports.

I have moved the is_radio_uri method to the supporting library. Also, we no longer build the album art URI by hand but use a value that is provided in push events.

This will probably break some use case with a radio station that I don't know about so I am re-enlisting as Sonos maintiner for two Home Assistant releases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob merged commit 699ca44 into home-assistant:dev Mar 21, 2020
@lock lock Bot locked and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants