Clean up Sonos attributes for radio streams#33063
Merged
balloob merged 1 commit intohome-assistant:devfrom Mar 21, 2020
Merged
Conversation
balloob
approved these changes
Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
media_artistandmedia_titleattributes that simply match the playing music (when available).Proposed change
Sonos apps have multiple display modes, like one for music streaming and one for radio streaming. The Sonos media_player integration has tried to mimic this by slightly misusing the entity attributes.
This PR removes all the special handling that tried to build information similar to Sonos apps and now simply uses the attributes that HA supports.
I have moved the
is_radio_urimethod to the supporting library. Also, we no longer build the album art URI by hand but use a value that is provided in push events.This will probably break some use case with a radio station that I don't know about so I am re-enlisting as Sonos maintiner for two Home Assistant releases.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: