Add effect service to WLED integration#33026
Merged
Merged
Conversation
7 tasks
Member
Author
|
Documentation PR created. Marked this PR ready for review. |
balloob
reviewed
Mar 21, 2020
| ATTR_PALETTE = "palette" | ||
| ATTR_PLAYLIST = "playlist" | ||
| ATTR_PRESET = "preset" | ||
| ATTR_REVERSE = "reverse" |
Member
There was a problem hiding this comment.
should this be called effect_reverse to make it clear what is being reversed ?
Member
Author
There was a problem hiding this comment.
The same can be said about speed for example.
I kept it consistent with that and the way it is used/displayed in WLED itself, just to stay close with that.
balloob
reviewed
Mar 21, 2020
balloob
approved these changes
Mar 21, 2020
ae1a93f to
272d576
Compare
Member
Author
|
Rebased PR onto the latest dev to deal with the merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a
wled.effectservice to the WLED integration.This allows the user to finetune the effects running on the WLED light (or set the light into a specific effect state, before turning it on.
Allows controlling:
Additionally, the
reverseattribute has been added to the light (since I figured it would be helpful if one could see the current state if one could set it.)Tests are added to keep the full coverage:
Type of change
Example automation
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: