Skip to content

Try all Samsung TV websocket ports #33001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 6 commits into from
Mar 21, 2020
Merged

Try all Samsung TV websocket ports #33001

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec031ea
Update bridge.py
escoand Mar 19, 2020
6d3af46
add test
escoand Mar 19, 2020
4095469
silence pylint
escoand Mar 19, 2020
f4a2c3a
correct pylint
escoand Mar 19, 2020
657b558
add some tests
escoand Mar 21, 2020
2bf9eac
Update test_media_player.py
escoand Mar 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/samsungtv/bridge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ def try_connect(self):
return RESULT_SUCCESS
except WebSocketException:
LOGGER.debug("Working but unsupported config: %s", config)

@LeoCal LeoCal Mar 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but I would suggest dropping a more meaningful message here, something like:
LOGGER.debug("Websocket connection attempt failed with the following config: %s", config)

@escoand escoand Mar 21, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes maybe it's a bit confusing but it describes exactly the problem: the connection is working but something went wrong, and if already the login fails it's apparently not like we support it.

return RESULT_NOT_SUPPORTED
if self.port != 8001:
Comment thread
escoand marked this conversation as resolved.
Outdated
return RESULT_NOT_SUPPORTED
except (OSError, ConnectionFailure) as err:
LOGGER.debug("Failing config: %s, error: %s", config, err)

Expand Down