Skip to content

Add Tesla sentry mode switch#32938

Merged
frenck merged 3 commits into
home-assistant:devfrom
hobbe:feat-tesla-sentry-mode-switch
Mar 23, 2020
Merged

Add Tesla sentry mode switch#32938
frenck merged 3 commits into
home-assistant:devfrom
hobbe:feat-tesla-sentry-mode-switch

Conversation

@hobbe
Copy link
Copy Markdown
Contributor

@hobbe hobbe commented Mar 18, 2020

Proposed change

Add a switch to the Tesla integration which enables/disables sentry mode.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @zabuldon, @alandtse, mind taking a look at this pull request as its been labeled with a integration (tesla) you are listed as a codeowner for? Thanks!

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs an update to teslajsonpy https://github.com/zabuldon/teslajsonpy/blob/master/teslajsonpy/sentry_mode.py doesn't seem to have a check to see if sentry mode is available.

cc @zabuldon @alandtse

Comment thread homeassistant/components/tesla/switch.py
@alandtse
Copy link
Copy Markdown
Contributor

I don't have any issues once the KeyError is addressed but someone like @MartinHjelmare should review.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 19, 2020

The KeyError check will solve the issue and move this forward, updating teslajsonpy to provide a similar method to what @hobbe described would be better as it means Home Assistant has to know less about the implementation details of teslajsonpy.

@hobbe
Copy link
Copy Markdown
Contributor Author

hobbe commented Mar 22, 2020

The switch will be marked unavailable if the vehicle does not support sentry mode.

Waiting for version 0.6.0 of library teslajsonpy.

@alandtse
Copy link
Copy Markdown
Contributor

Unless someone says you can't include it in this PR, I think you can bump it. Make sure you get it in the manifest.json and other documents. Just search for teslajsonpy.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 22, 2020

I'll retest shortly since I have a v1 tesla

@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label Mar 22, 2020
@frenck frenck merged commit 4332cbe into home-assistant:dev Mar 23, 2020
@hobbe hobbe deleted the feat-tesla-sentry-mode-switch branch March 23, 2020 15:37
@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants