Add Tesla sentry mode switch#32938
Conversation
bdraco
left a comment
There was a problem hiding this comment.
This probably needs an update to teslajsonpy https://github.com/zabuldon/teslajsonpy/blob/master/teslajsonpy/sentry_mode.py doesn't seem to have a check to see if sentry mode is available.
|
I don't have any issues once the KeyError is addressed but someone like @MartinHjelmare should review. |
|
The KeyError check will solve the issue and move this forward, updating teslajsonpy to provide a similar method to what @hobbe described would be better as it means Home Assistant has to know less about the implementation details of teslajsonpy. |
|
The switch will be marked unavailable if the vehicle does not support sentry mode. Waiting for version 0.6.0 of library teslajsonpy. |
|
Unless someone says you can't include it in this PR, I think you can bump it. Make sure you get it in the manifest.json and other documents. Just search for teslajsonpy. |
|
I'll retest shortly since I have a v1 tesla |
Proposed change
Add a switch to the Tesla integration which enables/disables sentry mode.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: