Add config flow for Nuheat#32885
Merged
Merged
Conversation
7 tasks
* Home Assistant state now mirrors the state displayed at mynewheat.com * Remove off mode as the device does not implement and setting was not implemented anyways * Implement missing set_hvac_mode for nuheat * Now shows as unavailable when offline * Add a unique id (serial number) * Fix hvac_mode as it was really implementing hvac_action * Presets now map to the open api spec published at https://api.mynuheat.com/swagger/ * ThermostatModel: scheduleMode
Its going to be more invasive to modernize the tests so it will have to come in a new pr
bdraco
force-pushed
the
nuheat_config_flow
branch
from
c1f33ba to
ee2223b
Compare
balloob
approved these changes
Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Removes the service as its now handled by set_hvac_mode (climate 1.0)
Proposed change
Add a config flow for nuheat
Rewrite the tests
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: