Skip to content

Enable sisyphus to recover from bad DNS without restart#32846

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
jkeljo:sisyphus-retry-connection
Apr 2, 2020
Merged

Enable sisyphus to recover from bad DNS without restart#32846
MartinHjelmare merged 1 commit intohome-assistant:devfrom
jkeljo:sisyphus-retry-connection

Conversation

@jkeljo
Copy link
Copy Markdown
Contributor

@jkeljo jkeljo commented Mar 15, 2020

Proposed change

If the initial attempt to contact the table fails outright, the sisyphus integration would throw PlatformNotReady forevermore. This PR fixes it so that each time we attempt to initialize the platform, it will make a new attempt to connect.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

The change to DNS settings around 0.97.2 (https://community.home-assistant.io/t/name-resolution-problem-since-0-97-2/132201/43) revealed this issue and provided an opportunity for testing. With this PR applied to my local instance, I tested as follows:

  1. Start HA with incorrect DNS settings
  2. Observe that the sisyphus integration reports not ready
  3. Run ha dns options to set the correct DNS settings
  4. Observe that the sisyphus integration starts successfully on the next retry
  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare added this to the 0.108.0 milestone Apr 2, 2020
@MartinHjelmare MartinHjelmare changed the title Enable sisyphus integration to recover from bad DNS without restarting HA Enable sisyphus to recover from bad DNS without restart Apr 2, 2020
@MartinHjelmare MartinHjelmare merged commit f8f05c4 into home-assistant:dev Apr 2, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants