Add support for AirVisual Node/Pro units#32815
Conversation
|
Marking this as WIP because just as I finished it, I learned that I may be able to access the data locally... 😱 Although the PR will be very similar, there is enough of a change that I'm going to close this one and will re-approach. |
|
Re-opening, as the work wasn't as bad as I'd anticipated. |
|
Please rebase to solve the merge conflicts. |
|
@MartinHjelmare It's on my to-do list. 👍 |
44f0755 to
53baaf1
Compare
|
Rebasing still on to-do list? |
|
@balloob I've rebased it twice thus far; since it's been hanging out, there have been ongoing changes in EDIT: ended up being pretty simple. 👍 |
6e56c48 to
bf2fb54
Compare
|
I know ADR-0010 has been approved since I originally created this; do I need to rip out |
|
We don't want to add more things to the config yaml. We also don't want to remove the config yaml without a deprecation period. Just add the new options to the config flow and leave the config yaml schema untouched, I think. |
|
Thanks, @MartinHjelmare. Going to move this to a draft in the meantime; no reason to review until it's fully ready. |
|
It ended up being pretty easy to remove |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! Just a small comment.
Proposed change
This PR adds support for AirVisual Node/Pro units to the
airvisualintegration. The integration talks to the device locally via Samba.Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: