Skip to content

UniFi - Make POE control switches configurable#32781

Merged
Kane610 merged 3 commits into
home-assistant:devfrom
Kane610:unifi-option_poe_client
Apr 2, 2020
Merged

UniFi - Make POE control switches configurable#32781
Kane610 merged 3 commits into
home-assistant:devfrom
Kane610:unifi-option_poe_client

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Mar 13, 2020

Breaking change

Proposed change

Make POE control switches configurable

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Please solve the merge conflict.

@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Apr 1, 2020

Thanks @MartinHjelmare

@Kane610 Kane610 merged commit 314bc07 into home-assistant:dev Apr 2, 2020
@Kane610 Kane610 deleted the unifi-option_poe_client branch April 2, 2020 15:53
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants