Allow multiple attribute reads in ZHA#32498
Merged
dmulcahey merged 9 commits intohome-assistant:devfrom Mar 7, 2020
Merged
Conversation
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
| battery_size = await self._channel.get_attribute_value("battery_size") | ||
| attributes = ["battery_size", "battery_quantity"] | ||
| results = await self._channel.get_attributes(attributes) | ||
| battery_size = results.get("battery_size", None) |
Member
There was a problem hiding this comment.
None is the default value returned if the key is missing in the dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds multiple attribute reads to ZHA and adds guards around attribute reads that could have caused unintended state flipping when remote requests failed.
Type of change
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: