Skip to content

Remove 'show all controls' option for Plex#32391

Merged
balloob merged 1 commit into
home-assistant:devfrom
jjlawren:plex_standard_controls
Mar 4, 2020
Merged

Remove 'show all controls' option for Plex#32391
balloob merged 1 commit into
home-assistant:devfrom
jjlawren:plex_standard_controls

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Mar 2, 2020

Breaking change

Deprecates a YAML & options config option and removes its associated functionality. Breaking config removal scheduled for the 0.110 release.

Proposed change

The ‘show all controls’ option has historically caused confusion as enabling it makes it appear that uncontrollable Plex clients are controllable. Additionally, client-specific workarounds regularly cause confusion and incorrect behavior. For example, NVIDIA SHIELD clients always appear controllable. Any client-specific workarounds should be pushed down into the underlying library’s domain.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
plex:
  media_player:
    show_all_controls: True  # Deprecated

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 2, 2020

Codecov Report

Merging #32391 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32391      +/-   ##
==========================================
- Coverage   94.75%   94.75%   -0.01%     
==========================================
  Files         776      776              
  Lines       56174    56173       -1     
==========================================
- Hits        53227    53226       -1     
  Misses       2947     2947
Impacted Files Coverage Δ
homeassistant/components/plex/config_flow.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da959c8...889703c. Read the comment docs.

@balloob balloob merged commit dd7d8d4 into home-assistant:dev Mar 4, 2020
@jjlawren jjlawren deleted the plex_standard_controls branch March 5, 2020 03:00
@lock lock Bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants