Remove 'show all controls' option for Plex#32391
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #32391 +/- ##
==========================================
- Coverage 94.75% 94.75% -0.01%
==========================================
Files 776 776
Lines 56174 56173 -1
==========================================
- Hits 53227 53226 -1
Misses 2947 2947
Continue to review full report at Codecov.
|
balloob
approved these changes
Mar 4, 2020
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Deprecates a YAML & options config option and removes its associated functionality. Breaking config removal scheduled for the 0.110 release.
Proposed change
The ‘show all controls’ option has historically caused confusion as enabling it makes it appear that uncontrollable Plex clients are controllable. Additionally, client-specific workarounds regularly cause confusion and incorrect behavior. For example, NVIDIA SHIELD clients always appear controllable. Any client-specific workarounds should be pushed down into the underlying library’s domain.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
The integration reached or maintains the following Integration Quality Scale: