Extend rtorrent sensor functionality#32353
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #32353 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 775 775
Lines 56171 56171
=======================================
Hits 53225 53225
Misses 2946 2946Continue to review full report at Codecov.
|
|
Please address all of my review comments :) |
|
I have changed all the ones you mentioned. |
|
I think you missed #32353 (comment) and #32353 (comment) ✌ |
|
True. I will change it soon. |
There was a problem hiding this comment.
LGTM 👍 btw you could open another PR to remove CONF_MONITORED_VARIABLES, see https://github.com/home-assistant/architecture/blob/master/adr/0003-monitor-condition-and-data-selectors.md
Nevertheless, the documentation needs to be updated as well :)
|
Docs PR is here: |
|
Thanks for updating the documentation :) |
Breaking change
Proposed change
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: