Skip to content

Extend rtorrent sensor functionality#32353

Merged
springstan merged 5 commits into
home-assistant:devfrom
smega:rtorrent-extension
Mar 13, 2020
Merged

Extend rtorrent sensor functionality#32353
springstan merged 5 commits into
home-assistant:devfrom
smega:rtorrent-extension

Conversation

@smega
Copy link
Copy Markdown
Contributor

@smega smega commented Feb 29, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
  - platform: rtorrent
    url: '<rtorrent_host>'
    monitored_variables:
      - 'current_status'
      - 'download_speed'
      - 'upload_speed'
      - 'all_torrents'
      - 'stopped_torrents'
      - 'complete_torrents'
      - 'uploading_torrents'
      - 'downloading_torrents'
      - 'active_torrents'

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @smega,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Extend rtorrent sensor functionality. Extend rtorrent sensor functionality Feb 29, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 29, 2020

Codecov Report

Merging #32353 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32353   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         775      775           
  Lines       56171    56171           
=======================================
  Hits        53225    53225           
  Misses       2946     2946

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab0411...9eebbc0. Read the comment docs.

Comment thread homeassistant/components/rtorrent/sensor.py Outdated
Comment thread homeassistant/components/rtorrent/sensor.py Outdated
Comment thread homeassistant/components/rtorrent/sensor.py Outdated
Comment thread homeassistant/components/rtorrent/sensor.py Outdated
Comment thread homeassistant/components/rtorrent/sensor.py Outdated
Comment thread homeassistant/components/rtorrent/sensor.py Outdated
Comment thread homeassistant/components/rtorrent/sensor.py Outdated
Comment thread homeassistant/components/rtorrent/sensor.py
@springstan
Copy link
Copy Markdown
Member

Please address all of my review comments :)

@smega
Copy link
Copy Markdown
Contributor Author

smega commented Mar 9, 2020

I have changed all the ones you mentioned.
Did I miss something?

@springstan
Copy link
Copy Markdown
Member

I think you missed #32353 (comment) and #32353 (comment)

@smega
Copy link
Copy Markdown
Contributor Author

smega commented Mar 9, 2020

True. I will change it soon.

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 btw you could open another PR to remove CONF_MONITORED_VARIABLES, see https://github.com/home-assistant/architecture/blob/master/adr/0003-monitor-condition-and-data-selectors.md

Nevertheless, the documentation needs to be updated as well :)

@smega
Copy link
Copy Markdown
Contributor Author

smega commented Mar 13, 2020

Docs PR is here:
home-assistant/home-assistant.io#12252

@springstan
Copy link
Copy Markdown
Member

Thanks for updating the documentation :)

@springstan springstan merged commit f3fed56 into home-assistant:dev Mar 13, 2020
@lock lock Bot locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants