Skip to content

Add abode support for CUE automations#32296

Merged
balloob merged 3 commits into
home-assistant:devfrom
shred86:abode_cue_no_tests
Mar 4, 2020
Merged

Add abode support for CUE automations#32296
balloob merged 3 commits into
home-assistant:devfrom
shred86:abode_cue_no_tests

Conversation

@shred86
Copy link
Copy Markdown
Contributor

@shred86 shred86 commented Feb 28, 2020

Breaking change

Abode is retiring its legacy automations and quick actions on 28 Feb (see Abode support article here). This change removes support for legacy automations and quick actions while adding support for CUE automations which will show up in Home Assistant as switches (same as previous implementation). Abode's replacement for quick actions is manually triggered CUE automations which can be called through Home Assistant service abode.trigger_automation (previously labeled abode.trigger_quick_action).

Proposed change

Removed support for Abode's legacy automations and quick actions being retired on 28 Feb. Adds support for Abode's new CUE automations which will show up as switches in Home Assistant (same as previously implementation). CUE automations can be called using the abode.trigger_automation service. Additionally, removed some unused variables and set the code_arm_required property for the alarm control panel to False (since it's not required and was showing up in the UI as True).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: #11984

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2020

Codecov Report

Merging #32296 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32296      +/-   ##
==========================================
+ Coverage   94.74%   94.75%   +0.01%     
==========================================
  Files         772      775       +3     
  Lines       55935    56171     +236     
==========================================
+ Hits        52995    53225     +230     
- Misses       2940     2946       +6
Impacted Files Coverage Δ
homeassistant/components/abode/config_flow.py 100% <100%> (ø) ⬆️
homeassistant/components/abode/const.py 100% <100%> (ø) ⬆️
homeassistant/components/lovelace/const.py 94.59% <0%> (-5.41%) ⬇️
homeassistant/helpers/storage.py 91.81% <0%> (-3.42%) ⬇️
...ssistant/components/islamic_prayer_times/sensor.py 94.62% <0%> (-0.06%) ⬇️
homeassistant/components/teksavvy/sensor.py 97.75% <0%> (-0.03%) ⬇️
homeassistant/components/startca/sensor.py 97.93% <0%> (-0.03%) ⬇️
homeassistant/components/climate/device_trigger.py 91.22% <0%> (ø) ⬆️
homeassistant/components/darksky/sensor.py 96.81% <0%> (ø) ⬆️
homeassistant/components/yr/sensor.py 88.05% <0%> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefbe02...d296bdc. Read the comment docs.

@balloob balloob merged commit d1beb92 into home-assistant:dev Mar 4, 2020
@shred86 shred86 deleted the abode_cue_no_tests branch March 6, 2020 23:01
@lock lock Bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants