Add application/xml as an XML to JSON auto converted mime types for rest sensors#32289
Merged
balloob merged 2 commits intohome-assistant:devfrom Mar 2, 2020
Merged
Add application/xml as an XML to JSON auto converted mime types for rest sensors#32289balloob merged 2 commits intohome-assistant:devfrom
balloob merged 2 commits intohome-assistant:devfrom
Conversation
…est sensors * Resolves issue home-assistant#32280
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev #32289 +/- ##
==========================================
+ Coverage 94.74% 94.75% +0.01%
==========================================
Files 772 775 +3
Lines 55935 56154 +219
==========================================
+ Hits 52994 53209 +215
- Misses 2941 2945 +4
Continue to review full report at Codecov.
|
springstan
approved these changes
Feb 28, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
Looks good 👍 just one small comment, could you please take a look?
7 tasks
Member
|
Marking it as a breaking change because it will change existing behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Add application/xml as an XML to JSON auto converted mime types for rest sensors
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: