Skip to content

Add application/xml as an XML to JSON auto converted mime types for rest sensors#32289

Merged
balloob merged 2 commits intohome-assistant:devfrom
bdraco:issue_32280_rfc2376
Mar 2, 2020
Merged

Add application/xml as an XML to JSON auto converted mime types for rest sensors#32289
balloob merged 2 commits intohome-assistant:devfrom
bdraco:issue_32280_rfc2376

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 27, 2020

Proposed change

Type of change

Add application/xml as an XML to JSON auto converted mime types for rest sensors

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2020

Codecov Report

Merging #32289 into dev will increase coverage by 0.01%.
The diff coverage is 96.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32289      +/-   ##
==========================================
+ Coverage   94.74%   94.75%   +0.01%     
==========================================
  Files         772      775       +3     
  Lines       55935    56154     +219     
==========================================
+ Hits        52994    53209     +215     
- Misses       2941     2945       +4
Impacted Files Coverage Δ
homeassistant/components/withings/const.py 100% <ø> (ø) ⬆️
homeassistant/components/darksky/sensor.py 96.81% <ø> (ø) ⬆️
homeassistant/components/wunderground/sensor.py 97.72% <ø> (ø) ⬆️
homeassistant/components/smartthings/sensor.py 100% <ø> (ø) ⬆️
homeassistant/components/demo/sensor.py 100% <ø> (ø) ⬆️
homeassistant/components/yr/sensor.py 88.05% <ø> (ø) ⬆️
homeassistant/components/teksavvy/sensor.py 97.75% <ø> (-0.03%) ⬇️
homeassistant/components/yweather/sensor.py 96.03% <ø> (ø) ⬆️
homeassistant/components/http/view.py 96.47% <ø> (ø) ⬆️
homeassistant/components/startca/sensor.py 97.93% <ø> (-0.03%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c86033...792944f. Read the comment docs.

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just one small comment, could you please take a look?

Comment thread tests/components/rest/test_sensor.py
@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 2, 2020

Marking it as a breaking change because it will change existing behavior.

@balloob balloob merged commit 924c313 into home-assistant:dev Mar 2, 2020
@lock lock Bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xmltojson conversion in rest sensor only supports Content-Type text/xml

4 participants