Remove ability to configure monitored conditions in IQVIA#32223
Merged
bachya merged 4 commits intohome-assistant:devfrom Feb 28, 2020
Merged
Remove ability to configure monitored conditions in IQVIA#32223bachya merged 4 commits intohome-assistant:devfrom
bachya merged 4 commits intohome-assistant:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #32223 +/- ##
==========================================
+ Coverage 94.74% 94.74% +<.01%
==========================================
Files 772 772
Lines 55935 55935
==========================================
+ Hits 52995 52996 +1
+ Misses 2940 2939 -1
Continue to review full report at Codecov.
|
balloob
reviewed
Feb 27, 2020
432022a to
092d245
Compare
balloob
reviewed
Feb 27, 2020
balloob
approved these changes
Feb 27, 2020
20 tasks
Member
|
@bachya Docs PR missing? |
Contributor
Author
|
@frenck Ack, sorry! Will get that done today. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
When configuring IQVIA via
configuration.yaml, themonitored_conditionskey has been deprecated and will be removed in 0.114.0. All sensors are now created by default.Proposed change
Per ADR 0003, this PR removes the ability to configure
monitored_conditionswithin IQVIA.This PR doesn't do anything to alter the data object (i.e., halt certain API calls if their entities are disabled); that will come in a subsequent PR.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: