Skip to content

Remove ability to configure monitored conditions in IQVIA#32223

Merged
bachya merged 4 commits intohome-assistant:devfrom
bachya:iqvia-no-monitored-conditions
Feb 28, 2020
Merged

Remove ability to configure monitored conditions in IQVIA#32223
bachya merged 4 commits intohome-assistant:devfrom
bachya:iqvia-no-monitored-conditions

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Feb 26, 2020

Breaking change

When configuring IQVIA via configuration.yaml, the monitored_conditions key has been deprecated and will be removed in 0.114.0. All sensors are now created by default.

Proposed change

Per ADR 0003, this PR removes the ability to configure monitored_conditions within IQVIA.

This PR doesn't do anything to alter the data object (i.e., halt certain API calls if their entities are disabled); that will come in a subsequent PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
iqvia:
  zip_code: !secret iqvia_zip_code

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2020

Codecov Report

Merging #32223 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32223      +/-   ##
==========================================
+ Coverage   94.74%   94.74%   +<.01%     
==========================================
  Files         772      772              
  Lines       55935    55935              
==========================================
+ Hits        52995    52996       +1     
+ Misses       2940     2939       -1
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 95.74% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e8d49...69099bd. Read the comment docs.

Comment thread homeassistant/components/iqvia/__init__.py Outdated
@bachya bachya requested review from a team, Jc2k and Kane610 as code owners February 27, 2020 22:11
@bachya bachya force-pushed the iqvia-no-monitored-conditions branch from 432022a to 092d245 Compare February 27, 2020 22:11
Comment thread homeassistant/components/iqvia/__init__.py Outdated
@bachya bachya removed request for Jc2k and Kane610 February 28, 2020 00:14
@bachya bachya merged commit 9329bc4 into home-assistant:dev Feb 28, 2020
@bachya bachya deleted the iqvia-no-monitored-conditions branch February 28, 2020 00:26
@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 28, 2020

@bachya Docs PR missing?

@bachya
Copy link
Copy Markdown
Contributor Author

bachya commented Feb 28, 2020

@frenck Ack, sorry! Will get that done today.

@lock lock Bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants