Add Config Flow for sense#32160
Merged
bachya merged 3 commits intohome-assistant:devfrom Feb 25, 2020
Merged
Conversation
* Fix unique ids so they are actually unique (and migrate the old ones) * Fix missing solar production * Do not mark sensors available until they have data
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev #32160 +/- ##
==========================================
+ Coverage 94.73% 94.75% +0.02%
==========================================
Files 767 768 +1
Lines 55486 55646 +160
==========================================
+ Hits 52562 52727 +165
+ Misses 2924 2919 -5
Continue to review full report at Codecov.
|
balloob
reviewed
Feb 25, 2020
balloob
reviewed
Feb 25, 2020
balloob
reviewed
Feb 25, 2020
balloob
reviewed
Feb 25, 2020
balloob
reviewed
Feb 25, 2020
balloob
reviewed
Feb 25, 2020
balloob
reviewed
Feb 25, 2020
balloob
reviewed
Feb 25, 2020
balloob
reviewed
Feb 25, 2020
balloob
approved these changes
Feb 25, 2020
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Looks good. Two final comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Config flow for sense.
Fix unique ids so they are actually unique (and migrate the old ones)
Fix missing solar production
Do not mark sensors available until they have data
Multiple sense units are now possible
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: