Skip to content

Add sighthound save image#32103

Merged
MartinHjelmare merged 10 commits into
home-assistant:devfrom
robmarkcole:adds_sighthoung_save_image
Feb 23, 2020
Merged

Add sighthound save image#32103
MartinHjelmare merged 10 commits into
home-assistant:devfrom
robmarkcole:adds_sighthoung_save_image

Conversation

@robmarkcole
Copy link
Copy Markdown
Contributor

Proposed change

Adds a config option which enables saving of an annotated image. I've not added a test as unsure how to test this safely, looking for recommendations. Docs PR home-assistant/home-assistant.io#11887

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

image_processing:
  - platform: sighthound
    api_key: my_key
    save_file_folder: /my_dir
    source:
      - entity_id: camera.local_file

Additional information

I cannot get my head around how to test this, advice requested

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@robmarkcole robmarkcole changed the title Adds sighthoung save image Adds sighthound save image Feb 23, 2020
Comment thread homeassistant/components/sighthound/image_processing.py Outdated
Comment thread homeassistant/components/sighthound/image_processing.py Outdated
Comment thread homeassistant/components/sighthound/image_processing.py Outdated
Comment thread homeassistant/components/sighthound/image_processing.py Outdated
Comment thread homeassistant/components/sighthound/image_processing.py Outdated
Comment thread tests/components/sighthound/test_image_processing.py Outdated
Comment thread tests/components/sighthound/test_image_processing.py Outdated
Comment thread tests/components/sighthound/test_image_processing.py Outdated
@MartinHjelmare MartinHjelmare changed the title Adds sighthound save image Add sighthound save image Feb 23, 2020
Comment thread tests/components/sighthound/test_image_processing.py Outdated
Comment thread tests/components/sighthound/test_image_processing.py Outdated
Comment thread tests/components/sighthound/test_image_processing.py Outdated
Comment thread tests/components/sighthound/test_image_processing.py Outdated
@codecov

This comment has been minimized.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 4cc4f07 into home-assistant:dev Feb 23, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants