Add name option for Frontier Silicon devices#32085
Merged
Merged
Conversation
…yaml Sometimes on start-up the component seems to be asked for the name before async_update has got it from the API resulting in the media_player becoming ‘unnamed_device’ thus ends up with a different entity ID breaking automations/Lovelace cards etc. that refer to it (and not looking good of course). Others have reported the same issue, e.g. home-assistant#18556
probot-home-assistant
Bot
added
integration: frontier_silicon
small-pr
jezcooke
changed the title
Merged
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev #32085 +/- ##
==========================================
+ Coverage 94.71% 94.72% +0.01%
==========================================
Files 766 767 +1
Lines 55568 55479 -89
==========================================
- Hits 52630 52553 -77
+ Misses 2938 2926 -12
Continue to review full report at Codecov.
|
springstan
changed the title
springstan
approved these changes
Feb 22, 2020
Member
springstan
left a comment
springstan
left a comment
There was a problem hiding this comment.
LGTM 👍 just one suggestion:
springstan
reviewed
Feb 22, 2020
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes on start-up the component seems to be asked for the name before async_update has got it from the API resulting in the media_player becoming ‘unnamed_device’ thus ends up with a different entity ID breaking automations/Lovelace cards etc. that refer to it (and not looking good of course).
Others have reported the same issue, e.g. #18556
Breaking change
Proposed change
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Added option to specify the name of Frontier Silicon devices home-assistant.io#12160
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: