Refactor Certificate Expiry Sensor#32066
Merged
jjlawren merged 15 commits intohome-assistant:devfrom Mar 2, 2020
Merged
Conversation
|
Hey there @cereal2nd, mind taking a look at this pull request as its been labeled with a integration ( |
20 tasks
Codecov Report
@@ Coverage Diff @@
## dev #32066 +/- ##
==========================================
+ Coverage 94.74% 94.76% +0.01%
==========================================
Files 768 777 +9
Lines 55639 56249 +610
==========================================
+ Hits 52714 53302 +588
- Misses 2925 2947 +22
Continue to review full report at Codecov.
|
phlet
reviewed
Feb 22, 2020
MartinHjelmare
requested changes
Feb 24, 2020
7e28b76 to
91a7eb9
Compare
Member
|
Please write a breaking change paragraph about the name config item deprecation. |
This was referenced Feb 25, 2020
Member
|
Should we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The
nameconfiguration option has been deprecated and is no longer used by the integration. An improved default entity & display naming scheme is provided. Name and entity_id overrides should be handled via the frontend.Configurations using
namewill marked broken with the 0.109 release.Proposed change
Based on feedback received in #32001, I've taken a different approach on fixing
cert_expirywhich has led to several changes:sslstarting with Python 3.7 and passes along new human-readable errors.sensor.cert_expiry_google_cominstead ofsensor.ssl_certificate_expiryorsensor.google)Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: