Pass in aiohttp session for ONVIF#32045
Merged
springstan merged 1 commit intodevfrom Feb 28, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #32045 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 766 766
Lines 55568 55568
=======================================
Hits 52630 52630
Misses 2938 2938 Continue to review full report at Codecov.
|
20 tasks
dgomes
approved these changes
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Pass in our
aiohttpsession into onvif.Currently, on a shutdown of Home Assistant it throws:
Which is not nice, however, as a workaround (and general improvement), it won't trigger this code if we pass in our aiohttp session.
This PR adds a transport for the underlying
zeeplibrary, which theonvif-zeep-asyncpackage is able to pass through.Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: