Skip to content

Pass in aiohttp session for ONVIF#32045

Merged
springstan merged 1 commit intodevfrom
frenck-2020-0223
Feb 28, 2020
Merged

Pass in aiohttp session for ONVIF#32045
springstan merged 1 commit intodevfrom
frenck-2020-0223

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Feb 20, 2020

Proposed change

Pass in our aiohttp session into onvif.

Currently, on a shutdown of Home Assistant it throws:

/home/frenck/code/home-assistant/home-assistant/venv/lib/python3.7/site-packages/zeep/asyncio/transport.py:61: RuntimeWarning: coroutine 'noop2' was never awaited
  self.session.connector.close()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

Which is not nice, however, as a workaround (and general improvement), it won't trigger this code if we pass in our aiohttp session.

This PR adds a transport for the underlying zeep library, which the onvif-zeep-async package is able to pass through.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
camera:
  - platform: onvif
    name: my_camera
    host: 192.168.1.2
    port: 8000
    username: admin
    password: admin

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2020

Codecov Report

Merging #32045 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32045   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         766      766           
  Lines       55568    55568           
=======================================
  Hits        52630    52630           
  Misses       2938     2938           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d58ab...9ce6ea5. Read the comment docs.

@springstan springstan merged commit 2390a7f into dev Feb 28, 2020
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2020-0223 branch February 28, 2020 10:46
@lock lock Bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants