Remove YAML config from Ring integration#32039
Merged
Merged
Conversation
7 tasks
frenck
reviewed
Feb 20, 2020
428b886 to
bc7904a
Compare
Closed
bc7904a to
8bafa17
Compare
Codecov Report
@@ Coverage Diff @@
## dev #32039 +/- ##
==========================================
- Coverage 94.71% 94.71% -0.01%
==========================================
Files 766 766
Lines 55568 55564 -4
==========================================
- Hits 52629 52625 -4
Misses 2939 2939
Continue to review full report at Codecov.
|
frenck
approved these changes
Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
All Ring accounts require two-factor authentication. This means that it is no longer possible to configure it via YAML as this cannot support 2FA.
Proposed change
Remove YAML configuration from Ring because it cannot support 2FA.
Docs have already been updated: home-assistant/home-assistant.io#12145
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: