Skip to content

Deprecate Xfinity Gateway integration (ADR-0004)#32017

Merged
pvizeli merged 1 commit into
devfrom
frenck-2020-0208
Feb 20, 2020
Merged

Deprecate Xfinity Gateway integration (ADR-0004)#32017
pvizeli merged 1 commit into
devfrom
frenck-2020-0208

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Feb 20, 2020

Breaking change

The Xfinity Gateway integration has been deprecated and pending removal in Home Assistant Core 0.109. It relies on web scraping to function, which is no longer allowed.

Proposed change

Deprecate Xfinity Gatway, since it relies on web scraping, the code owner suggested on deprecating and removing it (#31926).

ADR-0004.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @cisasteelersfan, mind taking a look at this pull request as its been labeled with a integration (xfinity) you are listed as a codeowner for? Thanks!

@pvizeli pvizeli merged commit d6c185f into dev Feb 20, 2020
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2020-0208 branch February 20, 2020 15:01
@lock lock Bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Xfinity Gateway integration violates ADR-0004

3 participants