Read Modbus climate current temp from input register#31944
Merged
springstan merged 1 commit intoFeb 18, 2020
Conversation
|
Hey there @adamchengtkc, mind taking a look at this pull request as its been labeled with a integration ( |
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev #31944 +/- ##
==========================================
+ Coverage 94.67% 94.67% +<.01%
==========================================
Files 763 763
Lines 55239 55239
==========================================
+ Hits 52295 52298 +3
+ Misses 2944 2941 -3
Continue to review full report at Codecov.
|
springstan
reviewed
Feb 18, 2020
springstan
approved these changes
Feb 18, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
Looks good! Just one more thing:
springstan
reviewed
Feb 18, 2020
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This change adds a new optional parameter
current_temp_register_typeintoModbus climateto allow reading values from both input registers (read-only) and holding registers (read and write). Because current temperature is always read and never written, it makes sense to allow such an option.This change was manually tested.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: