Skip to content

Read Modbus climate current temp from input register#31944

Merged
springstan merged 1 commit into
home-assistant:devfrom
Lutemi:feature/modbus-climate-register-type
Feb 18, 2020
Merged

Read Modbus climate current temp from input register#31944
springstan merged 1 commit into
home-assistant:devfrom
Lutemi:feature/modbus-climate-register-type

Conversation

@vzahradnik
Copy link
Copy Markdown
Contributor

@vzahradnik vzahradnik commented Feb 18, 2020

Proposed change

This change adds a new optional parameter current_temp_register_type into Modbus climate to allow reading values from both input registers (read-only) and holding registers (read and write). Because current temperature is always read and never written, it makes sense to allow such an option.

This change was manually tested.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
climate:
  - platform: modbus
    name: Watlow F4T
    hub: hub1
    slave: 1
    data_type: uint
    target_temp_register: 2782
    current_temp_register: 27586
    current_temp_register_type: input

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @adamchengtkc, mind taking a look at this pull request as its been labeled with a integration (modbus) you are listed as a codeowner for? Thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2020

Codecov Report

Merging #31944 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31944      +/-   ##
==========================================
+ Coverage   94.67%   94.67%   +<.01%     
==========================================
  Files         763      763              
  Lines       55239    55239              
==========================================
+ Hits        52295    52298       +3     
+ Misses       2944     2941       -3
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.68% <0%> (-1.07%) ⬇️
homeassistant/helpers/entity_registry.py 99.53% <0%> (ø) ⬆️
homeassistant/components/uk_transport/sensor.py 94.2% <0%> (+0.72%) ⬆️
homeassistant/components/template/cover.py 97.71% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e51619...054c352. Read the comment docs.

Comment thread homeassistant/components/modbus/climate.py Outdated
Comment thread homeassistant/components/modbus/climate.py Outdated
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one more thing:

Comment thread homeassistant/components/modbus/climate.py Outdated
@springstan springstan merged commit af67bb0 into home-assistant:dev Feb 18, 2020
@vzahradnik vzahradnik deleted the feature/modbus-climate-register-type branch February 18, 2020 17:47
@lock lock Bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants