Add support for SimpliSafe system notifications#31936
Merged
Merged
Conversation
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev #31936 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 763 763
Lines 55239 55239
=======================================
Hits 52295 52295
Misses 2944 2944
Continue to review full report at Codecov.
|
springstan
reviewed
Feb 18, 2020
springstan
approved these changes
Feb 18, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
LGTM ✌ thanks for implementing my suggested change :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds support for SimpliSafe system notification (firmware updates, etc.). These notifications will fire
SIMPLISAFE_NOTIFICATIONevents with this data:category: The notification category (e.g.,error)code: The SimpliSafe code for the notificationnotification_text: The actual text of the notificationtimestamp: The UTC timestamp of the notificationType of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: