Skip to content

UniFi config option SSID filter#31842

Merged
Kane610 merged 7 commits into
home-assistant:devfrom
Kane610:unifi-config_option_ssid_filter
Feb 18, 2020
Merged

UniFi config option SSID filter#31842
Kane610 merged 7 commits into
home-assistant:devfrom
Kane610:unifi-config_option_ssid_filter

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Feb 15, 2020

Breaking change

Proposed change

Allow SSID filter be set from config options, to help control what SSIDs wireless clients will be tracked on.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Kane610 Kane610 self-assigned this Feb 15, 2020
@Kane610 Kane610 force-pushed the unifi-config_option_ssid_filter branch from 6f20b59 to 9ceb21f Compare February 16, 2020 16:06
@Kane610 Kane610 marked this pull request as ready for review February 16, 2020 19:13
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Feb 16, 2020

This is ready for review, but I'd like to verify against the frontend PR before merging

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2020

Codecov Report

Merging #31842 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31842      +/-   ##
==========================================
- Coverage   94.69%   94.67%   -0.02%     
==========================================
  Files         763      764       +1     
  Lines       55210    55388     +178     
==========================================
+ Hits        52279    52440     +161     
- Misses       2931     2948      +17     
Impacted Files Coverage Δ
homeassistant/components/demo/config_flow.py 62.85% <0.00%> (-37.15%) ⬇️
homeassistant/util/logging.py 95.83% <0.00%> (-1.61%) ⬇️
homeassistant/helpers/entity_registry.py 99.53% <0.00%> (ø) ⬆️
homeassistant/components/deconz/climate.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/deconz/gateway.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/deconz/binary_sensor.py 98.03% <0.00%> (ø) ⬆️
homeassistant/components/twitch/sensor.py 96.73% <0.00%> (ø)
homeassistant/components/deconz/deconz_device.py 94.44% <0.00%> (+0.56%) ⬆️
homeassistant/components/deconz/sensor.py 96.82% <0.00%> (+0.79%) ⬆️
homeassistant/bootstrap.py 75.40% <0.00%> (+2.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b5d73...89e8e85. Read the comment docs.

@Kane610 Kane610 force-pushed the unifi-config_option_ssid_filter branch from 2ef357d to a996192 Compare February 17, 2020 19:03
Comment thread homeassistant/components/unifi/config_flow.py Outdated
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Feb 17, 2020

Verified and ready to go!

Comment thread tests/components/unifi/test_config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Kane610 Kane610 merged commit 774c892 into home-assistant:dev Feb 18, 2020
@Kane610 Kane610 deleted the unifi-config_option_ssid_filter branch February 18, 2020 22:24
@lock lock Bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants