Remove energy sensor from incompatible Ata devices#31831
Merged
MartinHjelmare merged 1 commit intoFeb 14, 2020
Merged
Conversation
An AtaDevice has a boolean flag describing whether it supports energy consumption metering. The flag was ignored resulting in sensor entities reporting constant 0 kWh consumption. * Update pymelcloud dependency to support the has_energy_consumed_meter flag. * Add ATTR_ENABLED_FN to sensor definitions for filtering out unsupported sensors. * Fix typing issue in sensor constructor. * Remove unused UnitSystem constructor parameter.
7 tasks
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
An
AtaDevicehas a boolean flag describing whether it supports energyconsumption metering. The flag was ignored resulting in sensor entities
reporting constant 0 kWh consumption. Not critical, but confusing for the user.
pymelclouddependency to support thehas_energy_consumed_meterflag.
ATTR_ENABLED_FNto sensor definitions for filtering outunsupported sensors.
UnitSystemconstructor parameter.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: