Skip to content

Add lg_netcast turn_on_action configuration variable#31792

Merged
springstan merged 1 commit into
home-assistant:devfrom
maxcanna:patch-1
Feb 15, 2020
Merged

Add lg_netcast turn_on_action configuration variable#31792
springstan merged 1 commit into
home-assistant:devfrom
maxcanna:patch-1

Conversation

@maxcanna
Copy link
Copy Markdown
Contributor

Proposed change

Allow to turn on the TV using an external service

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

  - platform: lg_netcast
    name: LGigi
    host: 192.168.0.70
    access_token: 123456
    turn_on_action:
      service: switch.turn_on
      data:
        entity_id: switch.lgigi

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov

This comment has been minimized.

Comment thread homeassistant/components/lg_netcast/media_player.py Outdated
@MartinHjelmare MartinHjelmare changed the title Add turn_on_action configuration variable Add lg_netcast turn_on_action configuration variable Feb 13, 2020
Comment thread homeassistant/components/lg_netcast/media_player.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Allow to turn on the TV using an external service
@maxcanna
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare I squashed the fixups 🙇

@MartinHjelmare
Copy link
Copy Markdown
Member

Please don't squash commits after review has started to make it easier for readers to track changes. We'll squash when merging. 👍

@maxcanna
Copy link
Copy Markdown
Contributor Author

Oh, sorry @MartinHjelmare I always pay attention to this. That's why I left them until you approved this PR. I'll leave them in the future 🙂

@MartinHjelmare
Copy link
Copy Markdown
Member

I need to check your squashed commit too, so I basically have to go through the PR again and for a big PR it would mean a lot of work.

No worries! Thanks for your contribution and I hope to see more!

@springstan springstan merged commit 4e54dfa into home-assistant:dev Feb 15, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants