Add lg_netcast turn_on_action configuration variable#31792
Merged
Conversation
7 tasks
This comment has been minimized.
This comment has been minimized.
MartinHjelmare
requested changes
Feb 13, 2020
Allow to turn on the TV using an external service
Contributor
Author
|
@MartinHjelmare I squashed the fixups 🙇 |
Member
|
Please don't squash commits after review has started to make it easier for readers to track changes. We'll squash when merging. 👍 |
MartinHjelmare
approved these changes
Feb 14, 2020
Contributor
Author
|
Oh, sorry @MartinHjelmare I always pay attention to this. That's why I left them until you approved this PR. I'll leave them in the future 🙂 |
Member
|
I need to check your squashed commit too, so I basically have to go through the PR again and for a big PR it would mean a lot of work. No worries! Thanks for your contribution and I hope to see more! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Allow to turn on the TV using an external service
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: