Skip to content

Add pigpio remote functionality#31667

Merged
springstan merged 1 commit into
home-assistant:devfrom
Poeschl:pigpio
Feb 18, 2020
Merged

Add pigpio remote functionality#31667
springstan merged 1 commit into
home-assistant:devfrom
Poeschl:pigpio

Conversation

@Poeschl
Copy link
Copy Markdown
Contributor

@Poeschl Poeschl commented Feb 9, 2020

Proposed change

This PR adds a host option to specify the host of the running pigpio daemon. This allows home-assistant to control also gpio pins on remote raspberry pi's.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
light:
  - platform: rpi_gpio_pwm
    leds:
      - name: Lightstrip Cupboard
        driver: gpio
        host: 127.0.0.1
        pins: [17]
        type: simple

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@springstan
Copy link
Copy Markdown
Member

@Poeschl isn't this the same as remote_rpi_gpio? 😄

@Poeschl
Copy link
Copy Markdown
Contributor Author

Poeschl commented Feb 9, 2020

As far as I looked it up, the remote_rpi_gpio toggles the pins in a binary way.
This component outputs an PWM signal on them. 😉

They are close and might be worth to combine in the future

@springstan
Copy link
Copy Markdown
Member

Completely agree looking deeper into it 😁

@Poeschl Poeschl requested a review from springstan February 18, 2020 08:14
@springstan springstan merged commit 0ae86b0 into home-assistant:dev Feb 18, 2020
@Poeschl Poeschl deleted the pigpio branch February 18, 2020 11:54
@lock lock Bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants