Skip to content

Catch garmin_connect keyerrors with unknown entity type updates#31608

Merged
MartinHjelmare merged 3 commits into
home-assistant:devfrom
cyberjunky:garmin-connect-keyerror-fix
Feb 8, 2020
Merged

Catch garmin_connect keyerrors with unknown entity type updates#31608
MartinHjelmare merged 3 commits into
home-assistant:devfrom
cyberjunky:garmin-connect-keyerror-fix

Conversation

@cyberjunky
Copy link
Copy Markdown
Contributor

@cyberjunky cyberjunky commented Feb 7, 2020

Catch KeyErrors when trying to update entities for which no value was found online.
Set Respiration type entities to entity_registry_enabled_default = False

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/garmin_connect/sensor.py Outdated
@MartinHjelmare MartinHjelmare changed the title Catch keyerrors with unknown entity type updates Catch garmin_connect keyerrors with unknown entity type updates Feb 8, 2020
@codecov

This comment has been minimized.

@MartinHjelmare MartinHjelmare merged commit 1093e25 into home-assistant:dev Feb 8, 2020
@frenck frenck added this to the 0.105.3 milestone Feb 9, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Garmin Connect: Error on device update!

5 participants