Skip to content

Add recorder vars db_max_retries and db_retry_wait#31561

Merged
springstan merged 9 commits into
home-assistant:devfrom
TechnicallyJoe:dev
Feb 9, 2020
Merged

Add recorder vars db_max_retries and db_retry_wait#31561
springstan merged 9 commits into
home-assistant:devfrom
TechnicallyJoe:dev

Conversation

@TechnicallyJoe
Copy link
Copy Markdown
Contributor

@TechnicallyJoe TechnicallyJoe commented Feb 6, 2020

Proposed change

Essentially, i'm proposing to add:

  • db_retry_wait:
  • db_max_retries:

to the recorder component. These are necessary because currently the retry count and sleep time is fixed to 10 retries, and 3 seconds sleep. I want to change that, so that its a variable.

The need came from an issue i had where my mariadb were consistently so slow to start, that my Home assistant container made its 10 retries and moved on. Testing shows that a completely new mariadb is about 2 mins to start up, so i was trying to figure out a way to force HA to check a bit more.
Proposed fixed were scripting the deploy, wrapping Home Assistant in a wait-for-it or dockerize container and using that to wait, but this seems like the best solution that benefits most people.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

default_config:

group: !include groups.yaml
automation: !include automations.yaml
script: !include scripts.yaml
scene: !include scenes.yaml

recorder:
  db_url: mysql://hass:hass@db:3306/hass?charset=utf8
  db_retry_wait: 10 # Wait 10 seconds between tries.
  db_max_retries: 20 # Try to connect 20 times.

Additional information

I have not submitted an issue for this however we did have a lengthy dicussion about this on discord Installation>Core around 12:27 AM the 6th of february. Here we discussed possible other solutions and came to the conclusion that this was probably the best solution.

Also, disclaimer. This is my first run with python. I'm a capable developer otherwise, but this is the first time i've ever done anything with python. Please let me know if you got any comments or anything im missing.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @TechnicallyJoe,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare MartinHjelmare changed the title added recorder vars db_max_retries and db_retry_wait Add recorder vars db_max_retries and db_retry_wait Feb 6, 2020
Comment thread homeassistant/components/recorder/__init__.py Outdated
Comment thread homeassistant/components/recorder/__init__.py Outdated
Comment thread homeassistant/components/recorder/__init__.py Outdated
Comment thread homeassistant/components/recorder/__init__.py Outdated
Comment thread homeassistant/components/recorder/__init__.py Outdated
Comment thread homeassistant/components/recorder/__init__.py Outdated
@springstan
Copy link
Copy Markdown
Member

@TechnicallyJoe thanks for implementing my suggested changes 😊
Please update the documentation accordingly in the documentation repo.

@TechnicallyJoe
Copy link
Copy Markdown
Contributor Author

@springstan
home-assistant/home-assistant.io#12023
Documentation PR added.

@springstan
Copy link
Copy Markdown
Member

Thanks @TechnicallyJoe!

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@springstan springstan merged commit 150b376 into home-assistant:dev Feb 9, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants