Skip to content

Updated the provider name to blockchain.com#31534

Merged
Quentame merged 2 commits into
home-assistant:devfrom
P-Verbrugge:patch-3
Feb 6, 2020
Merged

Updated the provider name to blockchain.com#31534
Quentame merged 2 commits into
home-assistant:devfrom
P-Verbrugge:patch-3

Conversation

@P-Verbrugge
Copy link
Copy Markdown
Contributor

Blockchain.info moved from .info .com. Updated the name of the service to blockchain.com

Breaking change

None

Proposed change

Updated the Blockchain service name from blockchain.info to blockchain.com

Type of change

  • Code quality improvements to existing code or addition of tests

  • This PR fixes or closes issue: fixes #

  • This PR is related to issue:

  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Blockchain.info moved from .info .com. Updated the name of the service to blockchain.com
Copy link
Copy Markdown
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change in manifest.json

Updated the provider name to blockchain.com
@P-Verbrugge
Copy link
Copy Markdown
Contributor Author

Also change in manifest.json

Done.

Next time I will see that I do a single pull request for two components when they are linked.

Copy link
Copy Markdown
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, also check home-assistant.io project to fix the documentation if needed.

You can tag me if you want.

@Quentame Quentame merged commit 4f21951 into home-assistant:dev Feb 6, 2020
@P-Verbrugge
Copy link
Copy Markdown
Contributor Author

Nice, also check home-assistant.io project to fix the documentation if needed.

You can tag me if you want.

Thanks for pointing that out. I just updated the documentation and tagged you (hopefully - learning the hard way).

@lock lock Bot locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants