Skip to content

Remove the liveboxplaytv integration (ADR0004)#31525

Merged
pvizeli merged 1 commit intodevfrom
frenck-2020-0159
Feb 6, 2020
Merged

Remove the liveboxplaytv integration (ADR0004)#31525
pvizeli merged 1 commit intodevfrom
frenck-2020-0159

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Feb 6, 2020

Breaking change

The Orange Livebox Play TV integration has been removed. A change to the site scraped with this integration has changed, causing the integration to break. This integration violated ADR-0004 and is therefore removed.

Proposed change

See breaking changes :)

It actually uses Beautiful Soup for this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @pschmitt, mind taking a look at this pull request as its been labeled with a integration (liveboxplaytv) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Remove of liveboxplaytv integration (ADR0004) Remove the liveboxplaytv integration (ADR0004) Feb 6, 2020
@pvizeli pvizeli merged commit 1cfd69d into dev Feb 6, 2020
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2020-0159 branch February 6, 2020 11:55
@lock lock Bot locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

liveboxplaytv: Error on device update!

3 participants