Skip to content

Clean up Tahoma smartlock#31430

Merged
springstan merged 2 commits into
home-assistant:devfrom
vlebourl:tahoma_smartlock
Feb 3, 2020
Merged

Clean up Tahoma smartlock#31430
springstan merged 2 commits into
home-assistant:devfrom
vlebourl:tahoma_smartlock

Conversation

@vlebourl
Copy link
Copy Markdown
Contributor

@vlebourl vlebourl commented Feb 3, 2020

Proposed change

Address comments from last PR that added support for tahoma smart locks.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @philklei, mind taking a look at this pull request as its been labeled with a integration (tahoma) you are listed as a codeowner for? Thanks!

@MartinHjelmare
Copy link
Copy Markdown
Member

Please rebase your branch on latest dev branch to solve the merge conflict and remove the old commits from the branch.

@vlebourl
Copy link
Copy Markdown
Contributor Author

vlebourl commented Feb 3, 2020

Tried to remove the old commits, but tbh, I don't know how to do that... I did a reset to HEAD and a new commit with the last version, but this doesn't seem to work...

Comment thread homeassistant/components/tahoma/lock.py Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

The branch looks ok now.

@vlebourl
Copy link
Copy Markdown
Contributor Author

vlebourl commented Feb 3, 2020

I'll wait for this one to be OK to write a PR for discovery_info for the other tahoma integrations.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Tahoma smartlock Clean up Tahoma smartlock Feb 3, 2020
@springstan springstan merged commit ad5db47 into home-assistant:dev Feb 3, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants