Add timeout attribute for send files#31379
Conversation
Remove attribute dublicate in BASE_SERVICE_SCHEMA
return attribute to BASE_SERVICE_SCHEMA and remove from SERVICE_SCHEMA_SEND_FILE
|
Please add the timeout variable to |
Codecov Report
@@ Coverage Diff @@
## dev #31379 +/- ##
==========================================
+ Coverage 94.41% 94.63% +0.22%
==========================================
Files 740 749 +9
Lines 53654 54185 +531
==========================================
+ Hits 50655 51276 +621
+ Misses 2999 2909 -90
Continue to review full report at Codecov.
|
Add timeout parameter description for "send message" and "send location"
| vol.Optional(ATTR_KEYBOARD): vol.All(cv.ensure_list, [cv.string]), | ||
| vol.Optional(ATTR_KEYBOARD_INLINE): cv.ensure_list, | ||
| vol.Optional(CONF_TIMEOUT): vol.Coerce(float), | ||
| vol.Optional(ATTR_TIMEOUT): cv.positive_int, |
There was a problem hiding this comment.
@MartinHjelmare does changing the expected data type of a service count as a breaking change?
There was a problem hiding this comment.
It could, but here I think we're backwards compatible. We're limiting it to positive numbers though. But a negative timeout sounds weird so I think that's ok.
|
So nothing really changed here except the service description additions? |
Not entirely, since the |
|
I don't see that change. Where is it? |
|
Oh yeah you are right, it was only replaced. So yes you could say that only the service descriptions were added. |
Breaking change
Proposed change
Add
timeoutparam to telegram_bot.send_file(send_video, send_photo, send_sticker, send_document) that help fixed issue withtimeouterror (with a large file size, poor internet connection, etc.)Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Documentation PR: Add telegram_chatbot
timeoutparametr. home-assistant.io#11944If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: