Add dump service to MQTT integration#31370
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
|
|
||
| async def async_dump_service(call: ServiceCall): | ||
| """Handle MQTT dump service calls.""" | ||
| messages = [] |
There was a problem hiding this comment.
Maybe the nonblock deque from collection they can limit the size and work as a ring buffer? So you have a third service option to limit the amount of messages?
There was a problem hiding this comment.
Since it's for debugging, we really want to have all the messages.
Codecov Report
@@ Coverage Diff @@
## dev #31370 +/- ##
==========================================
+ Coverage 94.60% 94.62% +0.02%
==========================================
Files 743 748 +5
Lines 53913 54128 +215
==========================================
+ Hits 51004 51221 +217
+ Misses 2909 2907 -2
Continue to review full report at Codecov.
|
|
Tagging this for the 105 so that it can help boost Z-Wave development. |
* Add dump service to MQTT integration * Lint
Breaking change
Proposed change
The new Z-Wave integration we're working on is based on MQTT. To help with debugging it's useful to be able to dump a whole OZW instance to a file.
I think that this can also be useful for debugging other integrations that are based on MQTT (zigbee2MQTT comes to mind).
To use the dumps in your Python code to replay them:
What do people think of this feature?
Docs: https://github.com/home-assistant/home-assistant.io/pull/11955/files
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: