Skip to content

Drop fritzdect integration#31359

Merged
balloob merged 1 commit intohome-assistant:devfrom
escoand:fritzdect_drop
Jan 31, 2020
Merged

Drop fritzdect integration#31359
balloob merged 1 commit intohome-assistant:devfrom
escoand:fritzdect_drop

Conversation

@escoand
Copy link
Copy Markdown
Contributor

@escoand escoand commented Jan 31, 2020

Breaking change

The integration fritzdect isn't available anymore.

Proposed change

The fritzdect integration is doing the exact same as fritzbox but the latter can do additional things.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Change this:

# Example configuration.yaml
switch:
  - platform: fritzdect
    username: YOUR_USERNAME
    password: YOUR_PASSWORD

to this:

# Example configuration.yaml
fritzbox:
  devices:
    - host: fritz.box
      username: YOUR_USERNAME
      password: YOUR_PASSWORD

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob merged commit d225fc0 into home-assistant:dev Jan 31, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 2, 2020
@escoand escoand deleted the fritzdect_drop branch February 2, 2020 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants