Fix misspelled danfoss_air sensor names#31344
Merged
Merged
Conversation
Contributor
Contributor
Author
|
I'm not sure, but I think that this is a breaking change, as it might change the entity_id of the sensors. |
Member
Yes that is a breaking change, please add a breaking change section to the PR template. |
springstan
approved these changes
Feb 1, 2020
Member
|
Shouldn't there be a docs update for fixing the spelling as well? Or are they correct in the docs and incorrect here? |
Member
|
@rohankapoorcom they are currently not listed in the docs, however you are right the docs should be updated. @KasperLK could you please update the documentation to include all danfoss air sensors? |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The names of some danfoss_air sensors include a misspelling of the word
danfoss.This typo has been corrected and you will need to adjust all occurrences respectively.
The following sensors are affected:
dandoss_air_dial_battery->danfoss_air_dial_batterydandoss_air_exhaust_fan_speed->danfoss_air_exhaust_fan_speeddandoss_air_supply_fan_speed->danfoss_air_supply_fan_speedProposed change
Fix missspelled sensor names.
Type of change