Skip to content

Fix misspelled danfoss_air sensor names#31344

Merged
springstan merged 1 commit into
home-assistant:devfrom
KasperLK:patch-1
Feb 3, 2020
Merged

Fix misspelled danfoss_air sensor names#31344
springstan merged 1 commit into
home-assistant:devfrom
KasperLK:patch-1

Conversation

@KasperLK
Copy link
Copy Markdown
Contributor

@KasperLK KasperLK commented Jan 31, 2020

Breaking change

The names of some danfoss_air sensors include a misspelling of the word danfoss.
This typo has been corrected and you will need to adjust all occurrences respectively.
The following sensors are affected:

  • dandoss_air_dial_battery -> danfoss_air_dial_battery
  • dandoss_air_exhaust_fan_speed -> danfoss_air_exhaust_fan_speed
  • dandoss_air_supply_fan_speed -> danfoss_air_supply_fan_speed

Proposed change

Fix missspelled sensor names.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @KasperLK,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@KasperLK
Copy link
Copy Markdown
Contributor Author

I'm not sure, but I think that this is a breaking change, as it might change the entity_id of the sensors.

@springstan
Copy link
Copy Markdown
Member

I'm not sure, but I think that this is a breaking change, as it might change the entity_id of the sensors.

Yes that is a breaking change, please add a breaking change section to the PR template.

@springstan springstan changed the title Fix misspelled sensor names Fix misspelled danfoss_air sensor names Jan 31, 2020
@rohankapoorcom
Copy link
Copy Markdown
Member

Shouldn't there be a docs update for fixing the spelling as well? Or are they correct in the docs and incorrect here?

@springstan
Copy link
Copy Markdown
Member

@rohankapoorcom they are currently not listed in the docs, however you are right the docs should be updated.

@KasperLK could you please update the documentation to include all danfoss air sensors?
Thanks 👍

@springstan springstan merged commit f5b7900 into home-assistant:dev Feb 3, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants