Update bt_smarthub component making it compatible with smarthub 2 by leroyshirto · Pull Request #31292 · home-assistant/core

leroyshirto · 2020-01-29T23:19:11Z

Proposed change

version 0.2.0 of the btsmarthub_devicelist package makes it compatible with BT's home hub 2 routers. The API of the library has changed. This change makes the component code compatible with the changes to the library.

This change resolves the 404 errors members in the comunity have been experiencing
jxwolstenholme/btsmarthub_devicelist#3
https://community.home-assistant.io/t/has-anyone-had-any-success-using-the-bt-home-hub-5-device-tracker-component-recently/38289/25

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example entry for `configuration.yaml`:

# Example configuration.yaml
device_tracker:
  - platform: bt_smarthub

Note: testing this requires a BT Smarthub or Smarthub 2.

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io
PR for documentation change Add optional configuration param for BT Smart Hub6 integration (#31292) home-assistant.io#11972

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

homeassistant · 2020-01-29T23:19:13Z

Hi @leroyshirto,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

probot-home-assistant · 2020-01-29T23:19:19Z

Hey there @jxwolstenholme, mind taking a look at this pull request as its been labeled with a integration (bt_smarthub) you are listed as a codeowner for? Thanks!

leroyshirto · 2020-01-31T06:52:02Z

@jxwolstenholme I have implemented the changes you suggested in your feedback. Please could you review the technical implementation?

As we are now offering a config option to users I will look at updating the docs to reflect.

jxwolstenholme · 2020-02-02T11:41:55Z

Looks good. Yes, agreed that the docs should be updated to confirm that Smarthub 2 support is now implemented.

jxwolstenholme

Approved from my end.

stale · 2020-03-21T17:27:40Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

frenck

Thanks, @leroyshirto, left 2 small comments.

MartinHjelmare

Please rebase on latest dev branch and solve the merge conflict.

MartinHjelmare

Great!

MartinHjelmare · 2020-04-15T11:19:05Z

/AzurePipelines run

azure-pipelines · 2020-04-15T11:19:17Z

Azure Pipelines successfully started running 1 pipeline(s).

MartinHjelmare · 2020-04-15T13:10:22Z

The CI checks on this page aren't updated properly. The formatting check failed:
https://dev.azure.com/home-assistant/Core/_build/results?buildId=37555&view=logs&j=2fa2c639-d05e-530d-034e-4fb413fcea4e&t=88bd70b9-15d8-56b4-acb9-94f6fcce0e9d

Please run black and commit the changes.

black --fast homeassistant

…T's home hub 2. The API has changed in the new version so this change also makes the component code compatible with the changes to the library.

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>

This should make BTSmartHubScanner easier to test as you can pass in a mock smarthub_client

leroyshirto · 2020-04-20T10:06:07Z

The CI checks on this page aren't updated properly. The formatting check failed:
https://dev.azure.com/home-assistant/Core/_build/results?buildId=37555&view=logs&j=2fa2c639-d05e-530d-034e-4fb413fcea4e&t=88bd70b9-15d8-56b4-acb9-94f6fcce0e9d

Please run black and commit the changes.
black --fast homeassistant

@MartinHjelmare Do we need to re-run Azure Pipelines after I fixed the formatting or does that happen automatically?

MartinHjelmare · 2020-04-20T18:43:34Z

A checks have passed now. 👍

MartinHjelmare

Thanks!

homeassistant added the cla-needed label Jan 29, 2020

probot-home-assistant Bot added integration: bt_smarthub small-pr PRs with less than 30 lines. labels Jan 29, 2020

homeassistant added cla-signed and removed cla-needed labels Jan 29, 2020

leroyshirto force-pushed the update-btsmarthub_devicelist-package branch 3 times, most recently from c822b65 to f5e7640 Compare January 31, 2020 06:45

jxwolstenholme approved these changes Feb 2, 2020

View reviewed changes

leroyshirto force-pushed the update-btsmarthub_devicelist-package branch from f5e7640 to f41fce9 Compare February 4, 2020 20:58

leroyshirto mentioned this pull request Feb 4, 2020

Add optional configuration param for BT Smart Hub6 integration (#31292) home-assistant/home-assistant.io#11972

Merged

7 tasks

leroyshirto marked this pull request as ready for review February 4, 2020 21:13

leroyshirto mentioned this pull request Feb 4, 2020

Home Assistant BT Smarthub 2 support jxwolstenholme/btsmarthub_devicelist#11

Closed

stale Bot added the stale label Mar 21, 2020

frenck reviewed Mar 22, 2020

View reviewed changes

Comment thread homeassistant/components/bt_smarthub/device_tracker.py Outdated

Comment thread homeassistant/components/bt_smarthub/device_tracker.py Outdated

stale Bot removed the stale label Mar 22, 2020

leroyshirto force-pushed the update-btsmarthub_devicelist-package branch from 483e3d0 to f41b36d Compare March 30, 2020 11:28

leroyshirto closed this Mar 30, 2020

leroyshirto deleted the update-btsmarthub_devicelist-package branch March 30, 2020 11:33

leroyshirto restored the update-btsmarthub_devicelist-package branch March 30, 2020 11:37

frenck reopened this Mar 30, 2020

MartinHjelmare requested changes Apr 15, 2020

View reviewed changes

Comment thread homeassistant/components/bt_smarthub/device_tracker.py Outdated

Comment thread homeassistant/components/bt_smarthub/device_tracker.py Outdated

leroyshirto force-pushed the update-btsmarthub_devicelist-package branch 2 times, most recently from c158858 to bc9b6d9 Compare April 15, 2020 10:51

leroyshirto requested a review from MartinHjelmare April 15, 2020 10:54

MartinHjelmare approved these changes Apr 15, 2020

View reviewed changes

leroyshirto and others added 5 commits April 15, 2020 16:29

0.2.0 of the btsmarthub_devicelist package makes it compatable with B…

5a25949

…T's home hub 2. The API has changed in the new version so this change also makes the component code compatible with the changes to the library.

Update homeassistant/components/bt_smarthub/device_tracker.py

3b099ff

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>

Update homeassistant/components/bt_smarthub/device_tracker.py

16939b8

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>

Remove dep on config in BTSmartHubScanner

b3fe9d8

This should make BTSmartHubScanner easier to test as you can pass in a mock smarthub_client

Black format bt_smarthub

2e4a325

leroyshirto force-pushed the update-btsmarthub_devicelist-package branch from bc9b6d9 to 2e4a325 Compare April 15, 2020 15:38

MartinHjelmare approved these changes Apr 20, 2020

View reviewed changes

MartinHjelmare merged commit 6fc517f into home-assistant:dev Apr 20, 2020

lock Bot locked and limited conversation to collaborators Apr 25, 2020

Uh oh!

Conversation

leroyshirto commented Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Example entry for configuration.yaml:

Additional information

Checklist

Uh oh!

homeassistant commented Jan 29, 2020

Uh oh!

probot-home-assistant Bot commented Jan 29, 2020

Uh oh!

leroyshirto commented Jan 31, 2020

Uh oh!

jxwolstenholme commented Feb 2, 2020

Uh oh!

jxwolstenholme left a comment

Choose a reason for hiding this comment

Uh oh!

stale Bot commented Mar 21, 2020

Uh oh!

frenck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare commented Apr 15, 2020

Uh oh!

azure-pipelines Bot commented Apr 15, 2020

Uh oh!

MartinHjelmare commented Apr 15, 2020

Uh oh!

leroyshirto commented Apr 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MartinHjelmare commented Apr 20, 2020

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

leroyshirto commented Jan 29, 2020 •

edited

Loading

Example entry for `configuration.yaml`:

leroyshirto commented Apr 20, 2020 •

edited

Loading