Add temperature and humidity to xiaomi miio air quality monitor

[fierland]

Proposed change

added 2 new attributes in the HASS entity:

• temperature
• humidity

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• [ x] New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Update air_quality.xiaomi_miio.markdown home-assistant.io#11945

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[homeassistant]

Hi @fierland,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with a integration (xiaomi_miio) you are listed as a codeowner for? Thanks!

[springstan]

Please update the documentation accordingly by opening a PR in home-assistant/home-assistant.io and link it to this one. Thanks 👍

[rytilahti]

LGTM, can be merged when the docs are updated 👍

[springstan]

@fierland please update the docs so this can be merged, thanks ✌😊

[fierland]

I thought I had updated the docs but I will check if the push worked Sincerely yours, Frank van Ierland 06-21391053

…

________________________________ From: springstan <notifications@github.com> Sent: Saturday, February 1, 2020 11:46:41 AM To: home-assistant/home-assistant <home-assistant@noreply.github.com> Cc: Frank van Ierland <frank@van-ierland.com>; Mention <mention@noreply.github.com> Subject: Re: [home-assistant/home-assistant] Add temperature and humidity to xiaomi miio air quality monitor (#31287) @fierland<https://github.com/fierland> please update the docs so this can be merged, thanks ✌😊 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31287>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AINVD65U4COG3MVB3BGSS5TRAVHJDANCNFSM4KNLWBUQ>.

[springstan]

You will need to create a separate PR in https://github.com/home-assistant/home-assistant.io and link it to this one :)

[fierland]

Mm what did i do wrong its pull request 6f43cd4 (home-assistant/home-assistant.io@6f43cd4) and linked to this one. Van: springstan <notifications@github.com> Verzonden: zaterdag 1 februari 2020 13:12 Aan: home-assistant/home-assistant <home-assistant@noreply.github.com> CC: Frank van Ierland <frank@van-ierland.com>; Mention <mention@noreply.github.com> Onderwerp: Re: [home-assistant/home-assistant] Add temperature and humidity to xiaomi miio air quality monitor (#31287) You will need to create a separate PR in https://github.com/home-assistant/home-assistant.io and link it to this one :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31287>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AINVD67P2P6MOW4VMK7TKCLRAVRKBANCNFSM4KNLWBUQ>.

[fierland]

Ok looks like its there now 😊 Van: springstan <notifications@github.com> Verzonden: zaterdag 1 februari 2020 13:12 Aan: home-assistant/home-assistant <home-assistant@noreply.github.com> CC: Frank van Ierland <frank@van-ierland.com>; Mention <mention@noreply.github.com> Onderwerp: Re: [home-assistant/home-assistant] Add temperature and humidity to xiaomi miio air quality monitor (#31287) You will need to create a separate PR in https://github.com/home-assistant/home-assistant.io and link it to this one :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31287>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AINVD67P2P6MOW4VMK7TKCLRAVRKBANCNFSM4KNLWBUQ>.

[springstan]

Great 👌

[fierland]

I realize that they should be a separate sensor although I see more entity’s with attributes that should be different. I’m new to coding for HASS so I started with this simple extension to make the data available. Have to digg into making a this integration with multiple entities . Are there any good examples for thIs?_____________________________

[MartinHjelmare]

Currently each xiaomi miio platform configures its own devices. I don't know how the device library handles multiple connection instances for the same host device.

Usually we try to have a central device connection that spawns multiple platforms that shares the central device. That would mean a major code refactor here.

If it's ok to set up multiple device connections, then we may just need to add the collection of humidity and temperature measurements to the xiaomi_miio sensor platform.