Skip to content

Add command 'ps_hold' to PS4#31283

Merged
springstan merged 1 commit into
home-assistant:devfrom
ktnrg45:ps4-105
Jan 29, 2020
Merged

Add command 'ps_hold' to PS4#31283
springstan merged 1 commit into
home-assistant:devfrom
ktnrg45:ps4-105

Conversation

@ktnrg45
Copy link
Copy Markdown
Contributor

@ktnrg45 ktnrg45 commented Jan 29, 2020

Proposed change

  • Add new command ps_hold as a valid command for the send_command service
  • Requires bump of pyps4-2ndsceen to 1.0.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@ktnrg45 ktnrg45 changed the title Add command 'ps_hold' Add command 'ps_hold' to PS4 Jan 29, 2020
Copy link
Copy Markdown
Contributor

@pnbruckner pnbruckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@springstan springstan added the dependency Pull requests marked as a dependency upgrade label Jan 29, 2020
@springstan springstan merged commit ee602e4 into home-assistant:dev Jan 29, 2020
@ktnrg45 ktnrg45 deleted the ps4-105 branch January 30, 2020 05:13
@lock lock Bot locked and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: ps4 small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants